Skip to content

Conversation

@egmontkob
Copy link
Contributor

Proposed changes

  • Use more consistent internal constant names for colors
  • New skin colors for frames
  • sand256 skin: Use non-italic frame characters

Checklist

👉 Our coding style can be found here: https://midnight-commander.org/coding-style/ 👈

  • I have referenced the issue(s) resolved by this PR (if any)
  • I have signed-off my contribution with git commit --amend -s
  • Lint and unit tests pass locally with my changes (make indent && make check)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Signed-off-by: Egmont Koblinger <egmont@gmail.com>
Signed-off-by: Egmont Koblinger <egmont@gmail.com>
…racters

Signed-off-by: Egmont Koblinger <egmont@gmail.com>
@github-actions github-actions bot added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels Dec 8, 2025
@github-actions github-actions bot added this to the Future Releases milestone Dec 8, 2025
@egmontkob egmontkob added area: tty Interaction with the terminal, screen libraries prio: low Minor problem or easily worked around and removed prio: medium Has the potential to affect progress needs triage Needs triage by maintainers labels Dec 8, 2025
@egmontkob egmontkob modified the milestones: Future Releases, 4.8.34 Dec 8, 2025
@egmontkob egmontkob requested a review from mc-worker December 8, 2025 15:53
@egmontkob
Copy link
Contributor Author

Here's the makeshift script I used to update the skin files: mc-4931-update-skins.sh

@egmontkob
Copy link
Contributor Author

Since the PR does not alter the look of any of the skins (except for that tiny italic fix), you'd have to create your own skin to test the change. Something like replacing all *frame = * with *frame = brightcyan; for testing purposes.

@egmontkob egmontkob merged commit 49c7c2f into MidnightCommander:master Dec 15, 2025
13 checks passed
@egmontkob egmontkob deleted the 4931-skin-frame-colors branch December 15, 2025 11:13
@egmontkob
Copy link
Contributor Author

frame.ini.txt

Here's a slight variation of the default skin, using differently colored frames.

Place in ~/.local/share/mc/skins/frame.ini (remove the .txt extension) and launch mc -S frame.

It's for demo purposes only, I don't mean to include this in mc, but hopefully some cool skins using this feature will emerge soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: tty Interaction with the terminal, screen libraries prio: low Minor problem or easily worked around

Development

Successfully merging this pull request may close these issues.

Skin: separate colors for frames

2 participants