Add RuntimeChannelPreferenceSet.md#3695
Merged
vickiez merged 10 commits intoapi-runtimeselectionfrom Apr 9, 2024
Merged
Conversation
david-risney
reviewed
Aug 8, 2023
david-risney
requested changes
Aug 8, 2023
vickiez
changed the title
david-risney
requested changes
Aug 18, 2023
kmahone
reviewed
Sep 15, 2023
oldnewthing
reviewed
Sep 19, 2023
FrankC-msft
reviewed
Sep 20, 2023
dmachaj
reviewed
Sep 21, 2023
dmachaj
reviewed
Sep 21, 2023
david-risney
requested changes
Sep 21, 2023
Contributor
david-risney
left a comment
david-risney
left a comment
There was a problem hiding this comment.
Please update per review feedback.
specs/ReleaseChannelPreferenceSet.md
Outdated
| // The Dev Runtime channel that is released weekly. | ||
| Dev = 4, | ||
| // The Canary Runtime channel that is released daily. | ||
| Canary = 8, |
Contributor
There was a problem hiding this comment.
Consider adding overloads of the version strings where we pull the channel out of the string as one of these enums
vickiez
added
the
review completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.