Add support for updating dependencies with custom attribute names#561
Merged
Mic92 merged 1 commit intoMic92:mainfrom Mar 1, 2026
Merged
Add support for updating dependencies with custom attribute names#561Mic92 merged 1 commit intoMic92:mainfrom
Mic92 merged 1 commit intoMic92:mainfrom
Conversation
ungeskriptet
force-pushed
the
custom-deps
branch
from
21bd930 to
b3496ff
Compare
Some packages need to fetch two different dependencies (e.g. OpenMetadata contains two yarn.lock files that need to be fetched). Add a new `--custom-dep` argument to allow updating dependencies with custom attribute names. Signed-off-by: David Wronek <david.wronek@mainlining.org>
ungeskriptet
force-pushed
the
custom-deps
branch
from
b3496ff to
8a623d6
Compare
Contributor
Author
|
I am aware that I could use subpackages to update the hashes, but that would require "wrapping" the fetcher (e.g. fetchYarnDeps) inside stdenv.mkDerivation, since it evaluates the subpackage a second time using eval.nix, which excepts arguments like |
13 tasks
Mynacol
added a commit
to Mynacol/nixpkgs
that referenced
this pull request
Mar 25, 2026
This commit rewrites the mullvad-browser package to be built from source. A great help was the build script in guix [1], seemingly the only other distro that builds this package from source. The original package is renamed to mullvad-browser-bin. I thought people might want to keep it to ensure it matches upstream in all regards affecting browser fingerprinting. But we can also drop it. It mostly just uses buildMozillaMach with settings that should mostly match upstream. To fix font rendering and use the font fingerprinting protection, all fonts are copied from the prebuilt release (retrieving them from the original sources is more work). The update script works (with it, I made the update to 15.0.8 today), but it depends on a freshly merged feature not yet available in a release nor nixpkgs [2]. I originally fetched the source tarball from cdn.mullvad.org and the other mirrors, but it complicates the update script, so it uses GitHub now. This package lacks language support besides en-US. I attempted to provide the correct files, but was blocked by the seeming lack of support by buildMozillaMach for it. This work is planned to be extended to also offer a source-built package for tor-browser. [1] https://codeberg.org/guix/guix/src/branch/master/gnu/packages/tor-browsers.scm [2] Mic92/nix-update#561
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some packages need to fetch two different dependencies (e.g. OpenMetadata contains two yarn.lock files that need to be fetched).
Add a new
--custom-depargument to allow updating dependencies with custom attribute names.