chore: Add treefmt pre-commit hook via git-hooks.nix#552
Closed
lafrenierejm wants to merge 1 commit intoMic92:mainfrom
Closed
chore: Add treefmt pre-commit hook via git-hooks.nix#552lafrenierejm wants to merge 1 commit intoMic92:mainfrom
lafrenierejm wants to merge 1 commit intoMic92:mainfrom
Conversation
The intent is to make it more convenient to maintain autoformatting locally and, in so doing, reduce iteration time on PRs.
Owner
|
Sorry but i don't like forced git precommit hooks. They constantly break my workflow. I rather want a pre-push hook, I think. Still many hooks can't tell what goes into one commit i.e mypy always operates on multiple files. So this is by definition incompatible with the way the pre-commit system is designed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent is to make it more convenient to maintain autoformatting locally and, in so doing, reduce iteration time on PRs.