Conversation
- CurveFunc argument is now expected [0,totalLength) - Bend function: curve time now has same "space" for stretched and non-stretched mode - Remove `unitLength` argument from some functions because it is not longer needed
Fedr
reviewed
Feb 12, 2026
| if ( params.periodicCurve ) | ||
| curveTime = curveTime - std::floor( curveTime ); | ||
| const auto pos = curve( curveTime ); | ||
| curveTime = std::fmodf( curveTime, curve.totalLength ); |
Contributor
There was a problem hiding this comment.
it does not work for negative curveTime
| /// given a polyline by its vertices, returns curve function representing it; | ||
| /// return an error if the polyline is less than 2 points or all points have exactly the same location | ||
| /// \param unitLength if true, then the lengths are normalized for the last point to have unit length | ||
| /// \param outCurveLen optional output of the total polyline length (before possible normalization) |
Contributor
There was a problem hiding this comment.
Suggested change
| /// \param outCurveLen optional output of the total polyline length (before possible normalization) | |
| /// \param outCurveLen optional output of the total polyline length |
Fedr
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unitLengthargument from some functions because it is not longer needed