Conversation
Fedr
approved these changes
Feb 4, 2026
source/MRIOExtras/MRSvg.cpp
Outdated
| int resolution = 32; | ||
| }; | ||
|
|
||
| Contour2f getEllipsePoints( const EllipseParams params = {} ) |
Contributor
There was a problem hiding this comment.
Suggested change
| Contour2f getEllipsePoints( const EllipseParams params = {} ) | |
| Contour2f getEllipsePoints( const EllipseParams& params = {} ) |
source/MRIOExtras/MRSvg.cpp
Outdated
| Vector2f end; | ||
| }; | ||
|
|
||
| std::vector<Vector2f> getPoints( Vector2f start, Vector2f& smoothControlPoint, CubicBezier cmd ) |
Contributor
There was a problem hiding this comment.
Suggested change
| std::vector<Vector2f> getPoints( Vector2f start, Vector2f& smoothControlPoint, CubicBezier cmd ) | |
| std::vector<Vector2f> getPoints( Vector2f start, Vector2f& smoothControlPoint, const CubicBezier& cmd ) |
source/MRIOExtras/MRSvg.cpp
Outdated
| Vector2f end; | ||
| }; | ||
|
|
||
| std::vector<Vector2f> getPoints( Vector2f start, Vector2f& smoothControlPoint, QuadraticBezier cmd ) |
Contributor
There was a problem hiding this comment.
please pass not changing structs by const reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.