Introduce SpaceMouse::HandlerWinEvents#5650
Merged
Conversation
oitel
reviewed
Jan 27, 2026
| if ( deviceSignal_ && localDevicesIt->usage == HID_USAGE_GENERIC_MULTI_AXIS_CONTROLLER && localDevicesIt->usage_page == HID_USAGE_PAGE_GENERIC ) | ||
| deviceSignal_( fmt::format( "HID API device {:04x}:{:04x} found: {}:{}", vendorId, localDevicesIt->product_id, | ||
| wideToUtf8( localDevicesIt->manufacturer_string ), wideToUtf8( localDevicesIt->product_string ) ) ); | ||
| TelemetrySignal( fmt::format( "HID API device {:04x}:{:04x} found: {}:{}", vendorId, localDevicesIt->product_id, |
Contributor
There was a problem hiding this comment.
Are usage/usage_page filters not required anymore?
| if ( auto handler = std::dynamic_pointer_cast< SpaceMouse::HandlerHidapi >( getViewerInstance().getSpaceMouseHandler() ) ) | ||
| return handler->hasValidDeviceConnected(); | ||
| auto handler = getViewerInstance().getSpaceMouseHandler(); | ||
| if ( handler ) |
source/MRViewer/MRViewer.cpp
Outdated
|
|
||
| } | ||
| #endif | ||
| #include "MRSpaceMouseHandlerWinEvents.h" |
Contributor
There was a problem hiding this comment.
Move to the top of the file.
oitel
approved these changes
Jan 27, 2026
Fedr
reviewed
Jan 27, 2026
| auto handler = Win32MessageHandler::getHandler( winHndl ); | ||
| if ( !handler || !handler->isValid() ) | ||
| { | ||
| assert( false && "invalid Win32MessageHandler while trying to initialize SpaceMouse::HandlerWinEvents" ); |
Contributor
There was a problem hiding this comment.
Suggested change
| assert( false && "invalid Win32MessageHandler while trying to initialize SpaceMouse::HandlerWinEvents" ); | |
| assert( !"invalid Win32MessageHandler while trying to initialize SpaceMouse::HandlerWinEvents" ); |
Fedr
approved these changes
Jan 27, 2026
| GetRawInputDeviceInfo( rawInput.header.hDevice, RIDI_DEVICENAME, name.data(), &nameSize ); // get name | ||
|
|
||
| spdlog::info( "SpaceMouse connected: {:04x}:{:04x}, path={}", vId, pId, wideToUtf8( name.c_str() ) ); | ||
| TelemetrySignal( fmt::format( "WIN API device {:04x}:{:04x} opened", vId, pId ) ); |
Contributor
There was a problem hiding this comment.
please pass device's name in telemetry as well
Fedr
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deviceSignaland replace it withtelemetry signalinitSpaceMouseHandlerprivate (there is no more need to keep it public)