Conversation
Fedr
approved these changes
Nov 18, 2025
source/MRViewer/MRDepthPeelingGL.h
Outdated
| void reset( const Vector2i& size ); | ||
|
|
||
| /// renders transparent objects into this buffer | ||
| /// returns true if there is transparent objects to render |
Contributor
There was a problem hiding this comment.
Suggested change
| /// returns true if there is transparent objects to render | |
| /// returns true if there are transparent objects to render |
| void FramebufferData::gen( const Vector2i& size, bool copyDepth, int msaaPow ) | ||
| void bindDepthPeelingTextures( GLuint shaderId, const TransparencyMode& tMode, GLenum startGLTextureIndex ) | ||
| { | ||
| if ( !tMode.isDepthPeelingEnbaled() ) |
Contributor
There was a problem hiding this comment.
Suggested change
| if ( !tMode.isDepthPeelingEnbaled() ) | |
| if ( !tMode.isDepthPeelingEnabled() ) |
Fedr
approved these changes
Nov 19, 2025
source/MRViewer/MRRenderGLHelpers.h
Outdated
| Vector2i size; // size of the viewport that is used in `draw` function | ||
| WrapType wrap{ WrapType::Clamp }; // wrap type of underlaying textures | ||
| FilterType filter{ FilterType::Linear }; // filter type of underlaying textures | ||
| bool forceSimpleDepthDraw = false; |
Contributor
There was a problem hiding this comment.
please add comment, what is simple
Fedr
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.