Allow override ancillary imgui label parameters#5019
Merged
Conversation
Fedr
reviewed
Aug 27, 2025
Comment on lines
+101
to
+104
| if ( !params ) | ||
| overrideParams_.reset(); | ||
| else | ||
| overrideParams_ = *params; |
Contributor
There was a problem hiding this comment.
why not simply: overrideParams_ = params;
adalisk-emikhaylov
requested changes
Aug 27, 2025
source/MRViewer/MRAncillaryLabels.h
Outdated
|
|
||
| /// Optionally override rendering params for this label | ||
| /// if not set defaults are used | ||
| MRVIEWER_API void resetParams( const std::optional<ImGuiMeasurementIndicators::Params>& params = std::nullopt ); |
Contributor
There was a problem hiding this comment.
Hmm, why "reset"? Perhaps something like setCustomParams or setOverrideParams.
adalisk-emikhaylov
approved these changes
Aug 27, 2025
Fedr
approved these changes
Aug 27, 2025
MaxRayskiy
pushed a commit
that referenced
this pull request
Sep 27, 2025
* Allow override ancillary imgui label parameters * CR Fix * CR Fix 2 * CR Fix 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.