added callback on change object in pick point manager#4766
Merged
Conversation
Grantim
reviewed
Jun 27, 2025
source/MRViewer/MRPickPointManager.h
Outdated
| PickerPointCallBack onPointRemove; | ||
|
|
||
| /// This callback is invoked when object was changed and needed update of points | ||
| /// Return true if update was processed |
Contributor
There was a problem hiding this comment.
please specify what it means? (true means that widget will skip internal updates?)
Fedr
reviewed
Jun 27, 2025
source/MRViewer/MRPickPointManager.h
Outdated
| public: | ||
| using PickerPointCallBack = std::function<void( std::shared_ptr<VisualObject> obj, int index )>; | ||
| using AllowCallBack = std::function<bool( const std::shared_ptr<VisualObject>& obj, int index )>; | ||
| using ChangeObjectCallBack = std::function<bool( std::shared_ptr<VisualObject>& obj )>; |
Contributor
There was a problem hiding this comment.
Better get shared_ptr by const reference
source/MRViewer/MRPickPointManager.h
Outdated
|
|
||
| /// This callback is invoked when an object was changed and needed update of points | ||
| /// Return true and widget will skip internal updates | ||
| ChangeObjectCallBack onChangeObject; |
Contributor
There was a problem hiding this comment.
Current name is confusing. Better name it e.g. onUpdatePoints and skip updating on false
Fedr
approved these changes
Jun 27, 2025
MaxRayskiy
pushed a commit
that referenced
this pull request
Sep 27, 2025
* added callback on change object in pick point manager * comments added * fixes after review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added callback for handling pick points on objects with changed topology