Merged
Conversation
Grantim
reviewed
May 23, 2025
source/MRViewer/MRRibbonSchema.cpp
Outdated
| continue; | ||
| auto dropItem = schema.items.find( dropRibItem->name() ); | ||
| if ( dropItem == schema.items.end() ) | ||
| if ( dropItem == schema.items.end() || !item->second.item ) |
Contributor
There was a problem hiding this comment.
same check as in 206 line?
Contributor
Author
There was a problem hiding this comment.
same logic, but for another object
source/MRViewer/MRRibbonSchema.cpp
Outdated
Comment on lines
+302
to
+308
| std::vector<SearchResult> res; | ||
| res.reserve( rawResult.size() ); | ||
| if ( params.weights ) | ||
| *params.weights = std::vector<SearchResultWeight>( rawResult.size() ); | ||
| { | ||
| params.weights->clear(); | ||
| params.weights->reserve( rawResult.size() ); | ||
| } |
Contributor
There was a problem hiding this comment.
why reserve and not resize?
Grantim
approved these changes
May 23, 2025
MaxRayskiy
pushed a commit
that referenced
this pull request
Sep 27, 2025
* fix potential crash in search * more fix * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.