Conversation
Fedr
reviewed
May 11, 2025
Fedr
reviewed
May 13, 2025
Fedr
reviewed
May 13, 2025
| for ( auto& pt : cube.points ) | ||
| pt = rot * pt; | ||
|
|
||
| auto offCube = weightedMeshShell( cube, WeightedPointsShellParametersRegions{ { 0.02f, 0.01f, 10.f }, {}, 0.f, false } ); |
Contributor
There was a problem hiding this comment.
Is 10 extra layers important for the test? Better test with the default values.
Member
Author
There was a problem hiding this comment.
Potentially, it highlights more errors.
Grantim
reviewed
May 16, 2025
Comment on lines
+35
to
+38
| /// either | ||
| /// 1) bidirectional distances are computed, or | ||
| /// 2) input location is locally outside of the surface (by pseudonormal) | ||
| bool bidirectionalOrOutside = true; |
Contributor
There was a problem hiding this comment.
Mb use enum instead of bool with two meanings?
Member
Author
There was a problem hiding this comment.
I think the point is that these two cases have the same operational meaning, so there is no point in separaring them.
Comment on lines
+95
to
+96
| /// find the closest point only if weighted bidirectional distance to it is less than given value | ||
| float maxBidirDist = FLT_MAX; |
Contributor
There was a problem hiding this comment.
does it work in bidirectionalMode=false?
Member
Author
There was a problem hiding this comment.
Yes, it is always used to set the maximum search radius
maxSearchRadius_( params.maxBidirDist + params.maxWeight )
Fedr
approved these changes
May 16, 2025
Grantim
approved these changes
May 16, 2025
MaxRayskiy
pushed a commit
that referenced
this pull request
Sep 27, 2025
* Determine outside/inside using pseudonormal to avoid artifacts near sharp edges. * Remove weight tricks. * Fix problem with points for which w > r. * Update `MeshPointAndDistance`. * `extraLayers` parameter and test. * Fix old test. * Fix windows warning. * Do not remesh. * Add continuity test. * fix build * Fix comparison. * in progress * code improvements * renamings * better names * `extraLayers` -> `numLayers`. * Add test that could highlight the limitation of the algorithm. * Fix comments. * Accelerate weightedMeshShell test --------- Co-authored-by: Fedor Chelnokov <fedor.chelnokov@meshinspector.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.