Merged
Conversation
--- + remove invalid SMB 2.??? mapping + select correct dialect in smb2_negotiate_protocol + handle wildcard dialect correctly in smb1_negotiate_protocol + fix parsing of negotiate context capabilities in SMB3_get_target_capabilities + remove hardcoded padding in smb2_negotiate + report invalid empty dialect list in smb1_negotiate_protocol and smb2_negotiate_protocol + fix invalid token length check in authenticate + change negotiate context padding to 0x00
MatrixEditor
added
Type - Bug
Protocol: SMB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #20