Use gfortran 11.3.0 from repackaged conda tarball for x86_64#11
Use gfortran 11.3.0 from repackaged conda tarball for x86_64#11mattip merged 5 commits intoMacPython:masterfrom
Conversation
|
This code is untested |
|
@isuruf I've just tried using the changes made in this PR in andyfaff/scipy#38. Unfortunately the compiler doesn't seem to work. I tried to compile a test program and I get: The test run is here. |
|
For the compiler to work, you need to set SDKROOT like you do for arm64 in https://github.com/scipy/scipy/blob/4b73d5e7150e05ac66baef19c6ddffc5ec4b3748/.github/workflows/wheels.yml#L175 |
|
Thanks @isuruf. Using gfortran 11.3.0 from conda-forge sounds great to me. Compiler version wise I'm not aware of any issues, and I've been using it locally on arm64 macOS for a little while. |
|
This is ready. The compilers here were tested by @andyfaff in the scipy CI and they work. |
|
Note, I used the |
|
Why didn't CI run? |
|
CI hasn't run in a while because the CI here used travis-ci.org and it was shut down ~6 months ago. We can move to travis-ci.com, but you'll run out of credits quickly. |
|
@isuruf: I think this should force the MACOSX_DEPLOYMENT_TARGET (in diff --git a/gfortran_utils.sh b/gfortran_utils.sh
index d2ac55f..8cd7573 100644
--- a/gfortran_utils.sh
+++ b/gfortran_utils.sh
@@ -25,9 +25,8 @@ function get_distutils_platform {
echo "manylinux1_$plat"
return
fi
- # macOS 32-bit arch is i386
- [ "$plat" == "i686" ] && plat="i386"
- local target=$(echo $MACOSX_DEPLOYMENT_TARGET | tr .- _)
+ # The gfortran downloads build for macos 10.9
+ local target="10_9"
echo "macosx_${target}_${plat}"
}
@@ -51,9 +50,8 @@ function get_distutils_platform_ex {
echo "manylinux${mb_ml_ver}_${plat}"
return
fi
- # macOS 32-bit arch is i386
- [ "$plat" == "i686" ] && plat="i386"
- local target=$(echo $MACOSX_DEPLOYMENT_TARGET | tr .- _)
+ # The gfortran downloads build for macos 10.9
+ local target="10_9"
echo "macosx_${target}_${plat}"
}
|
|
@mattip, we shouldn't force the target for other projects. It should be a per project setting. |
|
Maybe then a comment that 10.9 is supported, or a check that the value is at least 10.9? |
|
Yes, checking that the value is at least 10.9 is a good idea. |
No description provided.