Skip to content

docs(mddocs): add en mddocs from docs_rework#183

Open
annamikhailovapsk wants to merge 5 commits intodevelopfrom
feature/mddocs-en-folder
Open

docs(mddocs): add en mddocs from docs_rework#183
annamikhailovapsk wants to merge 5 commits intodevelopfrom
feature/mddocs-en-folder

Conversation

@annamikhailovapsk
Copy link

Change Summary

Created en folder documentation with documents in markdown

Related issue number

[DOP-28349]

Checklist

  • [ x ] Commit message and PR title is comprehensive
  • [ x ] Keep the change as small as possible
  • [ x ] Unit and integration tests for the changes exist
  • [ x ] Tests pass on CI and coverage does not decrease
  • [ x ] Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • [ x ] My PR is ready to review.

@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Coverage

Coverage Report •
FileStmtsMissBranchBrPartCoverMissing
TOTAL25282023088392% 
report-only-changed-files is enabled. No files were changed during this commit :)

@dolfinus dolfinus self-requested a review March 12, 2026 12:09
@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Mar 12, 2026
deactivate "Client"
@enduml
```
<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь и в dummy.md mermaid диаграмма закомментирована, в ldap.md нет


### `docker-compose.yml`

```default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Копировать docker-compose.yml не надо, нужно его подставлять и выделять нужные строки, которые важны для конкретного компонента

@@ -0,0 +1,5 @@
# 0.0.10 (2024-01-22) { #0.0.10 }
Copy link
Member

@dolfinus dolfinus Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Есть подозрение что якоря не могут содержать точки, и они должны выглядеть как version-0-0-10. Но это нужно проверить

```{eval-rst}
.. currentmodule:: horizon.commons.schemas.v1.user
``` -->
<!-- TODO: fix docstring extraction -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Проблема не исправилась?


## Base

### *class* horizon.commons.exceptions.base.ApplicationError
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Из docstring это не извлекается?

@@ -0,0 +1,167 @@
# SPDX-FileCopyrightText: 2025-present MTS PJSC
Copy link
Member

@dolfinus dolfinus Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это кусок конфига для sphinx, он точно здесь нужен? Как и mkdocs/Makefile и mkdocs/make.bat

Comment on lines +46 to +47
<<<<<<< HEAD:mddocs/conf.py
=======
Copy link
Member

@dolfinus dolfinus Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Конфликт при мерже


After successful auth, username is saved to backend database. It is then used for creating audit records for any object change, see `changed_by` field.

!!! warning ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кавычки точно нужны?

Comment on lines +57 to +58
```default
# development usage only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Посмотри на все вхождения default, скорее всего с ними та же проблема - вместо подстановок из файла (пример) копировалось их содержимое


## Example metrics

```default
Copy link
Member

@dolfinus dolfinus Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это точно работает? Три бэктика означают блок кодом, который не воспринимается парсером как markdown. И внутри этого блока мы зачем-то используем подстановку !include.

Да и почему default? Посте бэктиков пишется название языка

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants