Feat/generate source map #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jevakallio
reviewed
Aug 11, 2020
| "files.exclude": { | ||
| "**/.git": true, | ||
| "**/node_modules": true, | ||
| "**/node_modules": false, |
Collaborator
There was a problem hiding this comment.
I'm guessing the settings.json changes weren't intentional?
jevakallio
reviewed
Aug 11, 2020
| const IP_ADDRESS = ip.address(); | ||
| const PLATFORM = 'android'; | ||
| const requestURL = `http://${IP_ADDRESS}:${DEBUG_SERVER_PORT}/index.map?platform=${PLATFORM}&dev=true`; | ||
| return (await axios.get(requestURL)) as AxiosResponse<SourceMap>; |
Collaborator
There was a problem hiding this comment.
I don't think we need axios for this. Taking the dependency for a single http request is most likely not going to be popular among the react-native-cli maintainers
jevakallio
approved these changes
Aug 11, 2020
Collaborator
jevakallio
left a comment
jevakallio
left a comment
There was a problem hiding this comment.
Rubber stamping this, will address issues in group programming session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: