GH-754: Gas Price Optimisation - Hot Fix

[utkarshg6]

Note

Replaces margin-based gas logic with percentage-based increases and a constant bump for retries, updating constants, computation, and tests across pricing and blockchain layers.

• Gas pricing logic:
  • Replace DEFAULT_GAS_PRICE_MARGIN with DEFAULT_GAS_PRICE_RETRY_PERCENTAGE and add DEFAULT_GAS_PRICE_RETRY_CONSTANT in masq_lib/src/constants.rs.
  • Rename increase_gas_price_by_margin to increase_by_percentage in node/src/blockchain/blockchain_bridge.rs and update all callers (priced/new.rs, agent_web3.rs, blockchain_interface_web3/mod.rs, blockchain_interface_initializer.rs).
  • Retry computation change in priced/retry.rs:
    • If latest_gas_price_wei >= prev_gas_price_wei -> use increase_by_percentage(latest).
    • Else -> use prev + DEFAULT_GAS_PRICE_RETRY_CONSTANT.
  • Enforce gas price ceiling using the new calculations and adjust related log messages.
• Tests:
  • Update expected values to use increase_by_percentage and new retry rules across agent_web3.rs, blockchain_bridge.rs, blockchain_interface_web3/mod.rs, and initializer tests.
  • Add unit tests for compute_gas_price behavior in priced/retry.rs.
  • Adjust fee estimations and expected logs to reflect new pricing formula.

^{Written by Cursor Bugbot for commit 82cc8b7. This will update automatically on new commits. Configure here.}

[cursor]

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.