net_io.c doesn't check return codes

[habnabit]

In https://github.com/Lyude/SquirrelChat/blob/55d653e5e149524311aaf67d1273fa80405943b9/src/net_io.c there are several calls to send(2) which completely ignore the return code. As http://linux.die.net/man/2/send explains:

On error, -1 is returned, and errno is set appropriately.

If a signal happens to arrive while a send is in progress, errno will be set to EINTR. Since the return code is ignored, that means the write will be completely dropped on the floor. Similarly with the gnutls_write call (which is an alias for gnutls_record_send(3); see http://linux.die.net/man/3/gnutls_record_send for its man page):

If the EINTR is returned by the internal push function (the default is send()} then GNUTLS_E_INTERRUPTED will be returned. If GNUTLS_E_INTERRUPTED or GNUTLS_E_AGAIN is returned, you must call this function again, with the same parameters; [...]

[Lyude]

Ha! Wow, didn't think anyone would actually ever file an issue on this
seeing as it's been a while since I've worked on this program.
As for the issue you mentioned yes, you're completely right. I've actually
been aware of this for a while. It should be noted I wasn't as experienced
writing this as I am now. Problem is as of right now I don't have any plans
on continuing it for a while, and if I do a lot of that code is probably
going to be thrown out and replaced with code that makes better use of glib
(maybe). You're still welcome to send a pull request though if you want, I
don't think I'll be getting around to fixing this myself any time soon.
On Nov 21, 2014 3:02 PM, "Aaron Gallagher" notifications@github.com wrote:

In
https://github.com/Lyude/SquirrelChat/blob/55d653e5e149524311aaf67d1273fa80405943b9/src/net_io.c
there are several calls to send(2) which completely ignore the return
code. As http://linux.die.net/man/2/send explains:

On error, -1 is returned, and errno is set appropriately.

If a signal happens to arrive while a send is in progress, errno will be
set to EINTR. Since the return code is ignored, that means the write will
be completely dropped on the floor. Similarly with the gnutls_write call
(which is an alias for gnutls_record_send(3); see
http://linux.die.net/man/3/gnutls_record_send for its man page):

If the EINTR is returned by the internal push function (the default is
send()} then GNUTLS_E_INTERRUPTED will be returned. If GNUTLS_E_INTERRUPTED
or GNUTLS_E_AGAIN is returned, you must call this function again, with the
same parameters; [...]

—
Reply to this email directly or view it on GitHub
#10.