Add basic arbitrary-model-tests based fuzzing#14
Merged
Lokathor merged 4 commits intoLokathor:masterfrom Jan 13, 2020
Merged
Conversation
Owner
|
Looks good, all set to merge? |
Lokathor
approved these changes
Jan 13, 2020
Collaborator
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fuzzes the implementation against a reference model (in this case just a
Vecwith a bit of pre-validation of the operation to make it fixed length). After just a couple minutes of fuzzing I didn't find any behaviour differences, but it did find an underflow while calculating the end index fordrain(which after a little investigation also causes behaviour differences). I've fixeddrainand added edge-case tests for it.