Skip to content

ffmpeg: fix MFX session leak in QSV#88

Merged
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom
cgutman:qsv_leak
Jan 13, 2023
Merged

ffmpeg: fix MFX session leak in QSV#88
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom
cgutman:qsv_leak

Conversation

@cgutman
Copy link
Contributor

@cgutman cgutman commented Jan 13, 2023

Description

This fixes a bug in the QSV hwdevice context that causes MFX sessions (and thus the ID3D11Device and associated resources) to be leaked every time we open an encoder session.

This can't go upstream as-is due to conflicting changes in FFmpeg master, but I plan to submit a patch upstream too.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher merged commit fcda80b into LizardByte:nightly Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants