Skip to content

macOS aarch64#46

Merged
ReenigneArcher merged 57 commits intoLizardByte:nightlyfrom
brad-richardson:macos-arm64
Dec 20, 2022
Merged

macOS aarch64#46
ReenigneArcher merged 57 commits intoLizardByte:nightlyfrom
brad-richardson:macos-arm64

Conversation

@brad-richardson
Copy link
Copy Markdown
Contributor

@brad-richardson brad-richardson commented Dec 19, 2022

Description

Adds support for ARM on macOS. Note: neon has been disabled for FFmpeg which will likely make x265 (even more) unusable for this processor, but VideoToolbox hw encode should always be available.

Issues Fixed or Closed

N/A - prereq for sunshine mac arm support

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link
Copy Markdown
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not finished with this review, but here are some ideas

Copy link
Copy Markdown
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Just a few minor requests. I noticed some of the if/else items were not indented. I think you did this because my heredocs were not indented. But with one minor change it looks like they can be indented. If you wouldn't mind making that change, that would be super helpful.

I think this is good to go besides the if/else and heredoc indents.

@brad-richardson brad-richardson marked this pull request as ready for review December 20, 2022 16:45
@ReenigneArcher ReenigneArcher merged commit 127e83b into LizardByte:nightly Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants