Merged
Conversation
ReenigneArcher
requested changes
Dec 19, 2022
Member
ReenigneArcher
left a comment
There was a problem hiding this comment.
not finished with this review, but here are some ideas
ReenigneArcher
requested changes
Dec 20, 2022
Member
ReenigneArcher
left a comment
There was a problem hiding this comment.
This looks really good! Just a few minor requests. I noticed some of the if/else items were not indented. I think you did this because my heredocs were not indented. But with one minor change it looks like they can be indented. If you wouldn't mind making that change, that would be super helpful.
I think this is good to go besides the if/else and heredoc indents.
1360b52 to
57ea6a0
Compare
ReenigneArcher
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for ARM on macOS. Note: neon has been disabled for FFmpeg which will likely make x265 (even more) unusable for this processor, but VideoToolbox hw encode should always be available.
Issues Fixed or Closed
N/A - prereq for sunshine mac arm support
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.