amfenc: use updated (and working) HDR/colorspace patch#45
Merged
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom Dec 20, 2022
Merged
amfenc: use updated (and working) HDR/colorspace patch#45ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom
Conversation
With new patch set, default BT 601 colour reproduction looks much closer to software encoding. HDR support may also be fixed with this patch set. * Replace: 02-amf-color-fixes.patch with 01-amf-colorspace-v2.patch. Ref: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220907134122.1244-1-ovchinnikov.dmitrii@gmail.com/ * Rename: 01-idr-on-amf.patch -> 02-idr-on-amf.patch * Refresh patches to resolve conflicts: 02-idr-on-amf.patch, 03-amfenc-disable-buffering.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With new patch set, default BT 601 colour reproduction looks much closer to software encoding (to my eyes, the change to green intensity shows the starkest contrast but blue is still slightly less intense than libx264). HDR support may also be fixed with this patch set (but may require further work in Sunshine code).
Screenshot
Reference:

New patchset (BT. 601, captured via Moonlight):

Old patch (BT. 601, captured via Moonlight):

Issues Fixed or Closed
May affect HDR-related issues affecting AMD, but further work may be needed.
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.