Skip to content

amfenc: use updated (and working) HDR/colorspace patch#45

Merged
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom
psyke83:amf_colourspace_patch
Dec 20, 2022
Merged

amfenc: use updated (and working) HDR/colorspace patch#45
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom
psyke83:amf_colourspace_patch

Conversation

@psyke83
Copy link
Contributor

@psyke83 psyke83 commented Dec 19, 2022

Description

With new patch set, default BT 601 colour reproduction looks much closer to software encoding (to my eyes, the change to green intensity shows the starkest contrast but blue is still slightly less intense than libx264). HDR support may also be fixed with this patch set (but may require further work in Sunshine code).

Screenshot

Reference:
HDTV Ref

New patchset (BT. 601, captured via Moonlight):
HDTV New patchset

Old patch (BT. 601, captured via Moonlight):
HDTV Current

Issues Fixed or Closed

May affect HDR-related issues affecting AMD, but further work may be needed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

With new patch set, default BT 601 colour reproduction looks much closer to software encoding. HDR support may also be fixed with this patch set.

* Replace: 02-amf-color-fixes.patch with 01-amf-colorspace-v2.patch. Ref: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220907134122.1244-1-ovchinnikov.dmitrii@gmail.com/
* Rename: 01-idr-on-amf.patch -> 02-idr-on-amf.patch
* Refresh patches to resolve conflicts: 02-idr-on-amf.patch, 03-amfenc-disable-buffering.patch
@ReenigneArcher ReenigneArcher merged commit 7ae159c into LizardByte:nightly Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants