feat(build): make this a fullblown cmake project#370
Merged
ReenigneArcher merged 4 commits intomasterfrom Oct 30, 2024
Merged
Conversation
6fb99e1 to
cc1b6b1
Compare
a164fc6 to
a9b4874
Compare
Member
Author
|
@brad-richardson sorry for the ping, but hoping you can help shed some light on this question. I am trying to work towards making our whole FFmpeg build a cmake project, which would then allow us to include it as a subdirectory in Sunshine for cases where our pre-builts are not sufficient. I'm struggling to understand the cbs aspect, and why FFmpeg was configured and built 2 times. Is there some reason why we can't just configure FFmpeg once with the |
…ject # Conflicts: # .github/workflows/build-ffmpeg.yml # patches/FFmpeg/AMF/08-nvenc-av1-filler.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will make the whole project able to be built using CMake.
Known TODOs:
TODOs for later
Once this PR is complete, it will be easier to add new targets such as for Fedora using the
containeroption in CI.This PR is marked as a breaking change because it will require the following change to Sunshine.
Additionally,
ffmpegwill be replaced bydistin the published path. This is done to plan for item 2 in the future TODO list.Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist