Conversation
230a981 to
b9c14ef
Compare
43832f6 to
0ca250c
Compare
|
I tested the artifact from the latest run against nightly; |
|
I think we need to also update |
bc90d6d to
d68acb4
Compare
I've updated patch 01 (amf hdr) and 05 (qsv) with your suggested changes, but 02 (amf idr insertion) looks more complicated to implement. The AV1 frame types seem different, and I'm not certain how to map the values to the traditional I/B/P/IDR/SKIP frames. The header insertion logic also seems more complicated (with different alignment types), so I'm not 100% certain how to implement the necessary changes. |
d68acb4 to
44e48f1
Compare
f04be23 to
1863d14
Compare
cgutman
left a comment
There was a problem hiding this comment.
We can't merge this because FFmpeg 6.0 introduces a memory leak in the QSV context. We should be able to use FFmpeg 6.1 when it's released.
1863d14 to
bc79d5d
Compare
64c41a3 to
51740a8
Compare
Co-authored-by: Cameron Gutman <aicommander@gmail.com>
813450b to
51740a8
Compare
51740a8 to
0aeecac
Compare
0aeecac to
7b6647d
Compare
|
Leaving these notes here so we don't forget: For FFmpeg 6.1, we'll need to also change I believe the QSV encoders also gained a |
|
The AMF colourspace patch has also been updated to v3 (which includes av1 support): https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=9415 |
VDPAU is a decoding API, so we don't need it
|
Testing progress:
|
|
I'm satisfied that this build generally works. Let's merge this and we can perform final testing on the PR to the Sunshine repo. |
Description
Bump ffmpeg from v5.1 to master (9a3bbf8) and enable new AV1 encoders.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.