Skip to content

test(pytest): remove xfail markers #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Jun 27, 2025
Merged

test(pytest): remove xfail markers #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions tests/release_setup/test_release_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,9 @@ def test_set_github_action_output(github_output_file, outputs):

@pytest.mark.parametrize('version', [
('1970.1.1', False),
('2023.1127.235828', True), # TODO: update with real release from actions repo
('2025.627.5037', True),
])
def test_check_release(version):
# TODO: remove this after version number is updated to a real release
if version[1]:
pytest.xfail(reason="This will fail until we have an initial release to compare against.")

assert main.check_release(version=version[0]) == version[1]


Expand Down Expand Up @@ -167,7 +163,6 @@ def test_process_release_body(release_notes_sample):
assert result == release_notes_sample[1]


@pytest.mark.xfail(reason="This will fail until we have an initial release to compare against.")
def test_generate_release_body(github_token):
assert main.generate_release_body(tag_name='test', target_commitish=os.environ['GITHUB_SHA'])

Expand Down
Loading