Quote the path to sunshinesvc.exe when launching the termination helper

[cgutman]

Description

The path to sunshinesvc.exe needs to be quoted because it probably contains spaces, otherwise CreateProcess() will run C:\Program.exe if it's present. Fortunately, C:\ prohibits ordinary user writes, so this type of bug isn't exploitable unless the user has manually loosened ACLs on the system drive.

For good measure, let's just pass the path directly to CreateProcess() to avoid all the executable searching nonsense.

Screenshot

Issues Fixed or Closed

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

• I want maintainers to keep my branch updated

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.49%. Comparing base (7f795f0) to head (1be8f85).

Additional details and impacted files

@@           Coverage Diff            @@
##           nightly   #2379    +/-   ##
========================================
  Coverage     6.49%   6.49%            
========================================
  Files           85      85            
  Lines        18384   18384            
  Branches      8348    8348            
========================================
  Hits          1194    1194            
+ Misses       16149   15363   -786     
- Partials      1041    1827   +786     

Flag	Coverage Δ
Linux	4.43% <ø> (ø)
Windows	2.01% <ø> (ø)
macOS-12	8.71% <ø> (ø)
macOS-13	8.06% <ø> (ø)
macOS-14	8.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 30 files with indirect coverage changes