fix(logging): add logging namespace and create logging::init method#2336
Merged
ReenigneArcher merged 1 commit intonightlyfrom Apr 3, 2024
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nightly #2336 +/- ##
==========================================
+ Coverage 6.10% 6.50% +0.39%
==========================================
Files 85 85
Lines 18303 18382 +79
Branches 8319 8348 +29
==========================================
+ Hits 1118 1196 +78
+ Misses 16151 15360 -791
- Partials 1034 1826 +792
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7b2b47b to
1e2d83d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
57847c6 to
0e7bd21
Compare
FrogTheFrog
reviewed
Mar 31, 2024
FrogTheFrog
reviewed
Mar 31, 2024
|
|
||
| // Flush after each log record to ensure log file contents on disk isn't stale. | ||
| // This is particularly important when running from a Windows service. | ||
| sink->locked_backend()->auto_flush(true); |
Contributor
There was a problem hiding this comment.
If this is enabled, why are we even flushing manually?
Member
Author
There was a problem hiding this comment.
I'm not sure, perhaps the manual flush was just left over from before auto_flush was added? Maybe @cgutman has some idea?
0e083ed to
d9794e2
Compare
d9794e2 to
6e09df4
Compare
77e7eb0 to
e88ee8b
Compare
FrogTheFrog
suggested changes
Apr 1, 2024
d71a354 to
cfdef36
Compare
FrogTheFrog
reviewed
Apr 1, 2024
FrogTheFrog
reviewed
Apr 1, 2024
cfdef36 to
cfbf529
Compare
a31cf23 to
ac751ad
Compare
FrogTheFrog
reviewed
Apr 1, 2024
ac751ad to
51b6b20
Compare
51b6b20 to
b19a026
Compare
KuleRucket
pushed a commit
to KuleRucket/Sunshine
that referenced
this pull request
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Boost logs are captured in unit tests, and it was discovered that some encoder logging messages were not captured. This PR moves more (and hopefully all) logging setup to a
logging::initmethod.Example test output prior to this PR:
Todo:
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.