feat(i18n): add ui localization#2279
Merged
ReenigneArcher merged 1 commit intonightlyfrom Mar 22, 2024
Merged
Conversation
e38c0a9 to
9f18842
Compare
ReenigneArcher
commented
Mar 21, 2024
a242eab to
f74b996
Compare
ReenigneArcher
commented
Mar 21, 2024
62e9b78 to
6dccb0c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
1406e9e to
34266e7
Compare
34266e7 to
458e5df
Compare
458e5df to
6e55864
Compare
Co-Authored-By: TheElixZammuto <6505622+TheElixZammuto@users.noreply.github.com>
6e55864 to
24a2fbb
Compare
Member
Author
|
@cgutman FYI |
11 tasks
KuleRucket
pushed a commit
to KuleRucket/Sunshine
that referenced
this pull request
Jun 6, 2024
Co-authored-by: TheElixZammuto <6505622+TheElixZammuto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add localization to UI.
I followed this guide: https://vue-community.org/vue/translating-vue-js-applications-with-vue-i18n.html
Some formatting was removed from strings, especially in config descriptions. This was done to make it both easier to translate, and easier to contribute to the source code.
Todo:
en.json/src_assets/common/assets/web/locale/or/locale/(2nd option is my preference... but build works as is)/src_assets/common/assets/web/locale/sunshine.jsonas the default file or/src_assets/common/assets/web/locale/en/sunshine.json(fix(i18n): allow localizing preferences page Themerr-plex#398 will be a good test of how crowdin handles this)<b>SOMETHING</b>Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.