Don't hardcode the signature length to RSA-2048#1872
Merged
cgutman merged 2 commits intoLizardByte:nightlyfrom Dec 1, 2023
Merged
Don't hardcode the signature length to RSA-2048#1872cgutman merged 2 commits intoLizardByte:nightlyfrom
cgutman merged 2 commits intoLizardByte:nightlyfrom
Conversation
ReenigneArcher
approved these changes
Nov 30, 2023
ReenigneArcher
requested changes
Nov 30, 2023
Member
ReenigneArcher
left a comment
There was a problem hiding this comment.
I approved it before I realized there are mentions in the docs about the length being 2048.
https://docs.lizardbyte.dev/projects/sunshine/en/latest/about/advanced_usage.html#pkey
https://docs.lizardbyte.dev/projects/sunshine/en/latest/about/advanced_usage.html#cert
Collaborator
Author
|
Good catch, I didn't realize we documented that limitation. I pushed an update to those docs. |
ReenigneArcher
approved these changes
Dec 1, 2023
Member
|
Thanks! Feel free to merge whenever. |
KuleRucket
pushed a commit
to KuleRucket/Sunshine
that referenced
this pull request
Jun 6, 2024
e-dong
pushed a commit
to e-dong/Sunshine
that referenced
this pull request
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the hardcoded assumption that signatures will always be 256 bytes long (corresponding to RSA-2048). With this change, we can support larger 3072 or 4096 bit RSA keys or other algorithms like ECDSA. Moonlight clients also need to be running updated code that corrects this assumption on their side too.
Interestingly, GFE has the same bug and won't tolerate anything but RSA-2048 keys.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.