Skip to content

Don't hardcode the signature length to RSA-2048#1872

Merged
cgutman merged 2 commits intoLizardByte:nightlyfrom
cgutman:flexible_signature_length
Dec 1, 2023
Merged

Don't hardcode the signature length to RSA-2048#1872
cgutman merged 2 commits intoLizardByte:nightlyfrom
cgutman:flexible_signature_length

Conversation

@cgutman
Copy link
Copy Markdown
Collaborator

@cgutman cgutman commented Nov 30, 2023

Description

This PR fixes the hardcoded assumption that signatures will always be 256 bytes long (corresponding to RSA-2048). With this change, we can support larger 3072 or 4096 bit RSA keys or other algorithms like ECDSA. Moonlight clients also need to be running updated code that corrects this assumption on their side too.

Interestingly, GFE has the same bug and won't tolerate anything but RSA-2048 keys.

Screenshot

image

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link
Copy Markdown
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgutman
Copy link
Copy Markdown
Collaborator Author

cgutman commented Dec 1, 2023

Good catch, I didn't realize we documented that limitation. I pushed an update to those docs.

@ReenigneArcher
Copy link
Copy Markdown
Member

Thanks! Feel free to merge whenever.

@cgutman cgutman merged commit 3b9e37e into LizardByte:nightly Dec 1, 2023
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
e-dong pushed a commit to e-dong/Sunshine that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants