ci(tests): add test framework#1603
Merged
ReenigneArcher merged 2 commits intonightlyfrom Mar 24, 2024
Merged
Conversation
ReenigneArcher
force-pushed
the
ci(tests)-add-test-framework
branch
12 times, most recently
from
7cf50b9 to
43df3dc
Compare
psyke83
reviewed
Sep 6, 2023
ReenigneArcher
force-pushed
the
ci(tests)-add-test-framework
branch
3 times, most recently
from
6e00c37 to
eab16f8
Compare
11 tasks
ReenigneArcher
force-pushed
the
ci(tests)-add-test-framework
branch
from
eab16f8 to
040c3a6
Compare
ReenigneArcher
force-pushed
the
ci(tests)-add-test-framework
branch
6 times, most recently
from
0030976 to
dfaa57e
Compare
ReenigneArcher
force-pushed
the
ci(tests)-add-test-framework
branch
18 times, most recently
from
bfebe5a to
547b1ac
Compare
ReenigneArcher
commented
Feb 20, 2024
Member
Author
There was a problem hiding this comment.
Does any of this need to be broken out into a header file?
|
|
||
| TEST(FileHandlerTests, ReadFileTest) { | ||
| // read file from WriteFileTest | ||
| EXPECT_EQ(file_handler::read_file("write_file_test.txt"), "test\n"); // sunshine adds a newline |
Member
Author
There was a problem hiding this comment.
Should Sunshine be adding a \n?
tests/conftest.cpp
Outdated
| std::string originalEnvPath; | ||
| }; | ||
|
|
||
| class DocsPythonVenvTest : public virtual BaseTest, public DocsPythonVenvBase { |
Member
Author
There was a problem hiding this comment.
I'm not really a fan of these secondary classes, but I don't know how to make it work without them.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This was referenced Feb 26, 2024
3 tasks
ReenigneArcher
commented
Mar 18, 2024
This was referenced Mar 24, 2024
This was referenced Mar 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a test framework and initial unit tests. Replaces #1323.
Tests are run in all CI builds (except flatpak right now as it's failing to build). Doc Tests are skipped on macOS (due to dependencies relying on homebrew boost), but are enabled in the Macports build.
Other updates:
Todo:
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.