Fix Sequence violating spirit of sequence #430
Conversation
A cursor is not a cursor if it not being lazily evaluated. And it definitely isn't useful for reading data as it blows up the memory when reading larger collections tricking downstream into thinking it is streaming friendly.
|
@sepatel have you read the doc ? https://litote.org/kmongo/extensions-overview/#use-sequences |
Read through it, still feels odd/wrong that a sequence should be non-streamable and a completely new way of doing things be the protection for closing a connection that hasn't been fully consumed. But as I don't have a better solution off hand on how to deal with the unconsumed resources of a connection without breaking backwards compatibility (cause honestly it feels that this edge cause should have used a special wrapping function not the normal use case), I'll let this matter drop. I know this is a deprecated project anyway and so we just hacked around it with our own custom methods that make it a normal raw cursor event instead. |
2 participants
These changes look to restore the Sequence behavior to be that of a Sequence.
Fixes #429