Skip to content

Replace readex pro with noto sans arabic#1056

Open
JerryMerweather wants to merge 9 commits intoLinwoodDev:developfrom
JerryMerweather:develop
Open

Replace readex pro with noto sans arabic#1056
JerryMerweather wants to merge 9 commits intoLinwoodDev:developfrom
JerryMerweather:develop

Conversation

@JerryMerweather
Copy link
Copy Markdown
Contributor

@JerryMerweather JerryMerweather commented Mar 29, 2026

I know I have been very messy with pull requests, and I am sorry.

I have realized that READEX PRO doesn't fit the calm and smooth font comfortaa.
noto sans arabic is less bold and is more fitting for comfortaa, In my opinion.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the app’s typography configuration by replacing the Readex Pro Arabic fallback with Noto Sans Arabic, aligning the fallback font choice with the app’s primary Comfortaa font and updating the associated license registration.

Changes:

  • Switch Flutter font family config from ReadexPro to NotoSansArabic in pubspec.yaml.
  • Update theme fallback fonts to use NotoSansArabic instead of ReadexPro.
  • Update license loading/asset listing to use fonts/NotoSansArabic-LICENSE.txt.

Reviewed changes

Copilot reviewed 4 out of 18 changed files in this pull request and generated 1 comment.

File Description
app/pubspec.yaml Replaces the configured Arabic fallback font family and swaps the license asset entry.
app/lib/theme.dart Updates fontFamilyFallback to prefer NotoSansArabic.
app/lib/setup.dart Updates license registration to load the Noto Sans Arabic license file.
app/fonts/NotoSansArabic-LICENSE.txt Updates license text header to the Noto project attribution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +157 to +166
- asset: fonts/NotoSansArabic-Light.ttf
weight: 300
- asset: fonts/NotoSansArabic-Regular.ttf
weight: 400
- asset: fonts/NotoSansArabic-Medium.ttf
weight: 500
- asset: fonts/NotoSansArabic-SemiBold.ttf
weight: 600
- asset: fonts/NotoSansArabic-Bold.ttf
weight: 700
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The YAML indentation for the fonts: list under family: NotoSansArabic is invalid: the - asset: entries need to be indented under the fonts: key (same pattern used by Comfortaa/Roboto below). As written, this will likely break flutter pub get/font registration.

Suggested change
- asset: fonts/NotoSansArabic-Light.ttf
weight: 300
- asset: fonts/NotoSansArabic-Regular.ttf
weight: 400
- asset: fonts/NotoSansArabic-Medium.ttf
weight: 500
- asset: fonts/NotoSansArabic-SemiBold.ttf
weight: 600
- asset: fonts/NotoSansArabic-Bold.ttf
weight: 700
- asset: fonts/NotoSansArabic-Light.ttf
weight: 300
- asset: fonts/NotoSansArabic-Regular.ttf
weight: 400
- asset: fonts/NotoSansArabic-Medium.ttf
weight: 500
- asset: fonts/NotoSansArabic-SemiBold.ttf
weight: 600
- asset: fonts/NotoSansArabic-Bold.ttf
weight: 700

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants