fixed default fractional julian day number calculation#40
Open
micampe wants to merge 1 commit intoLighter-swift:developfrom
Open
fixed default fractional julian day number calculation#40micampe wants to merge 1 commit intoLighter-swift:developfrom
micampe wants to merge 1 commit intoLighter-swift:developfrom
Conversation
Formula deduced from information at https://aa.usno.navy.mil/data/JulianDate
Member
|
Hm, I think my rational was that one would store a I'm a bit split on this. |
Contributor
Author
|
I have no stake in this, I am not using it, I fixed it just because I noticed the discrepancy. I agree, unclear which choice is the best. a couple of notes:
|
Member
|
Funny enough SQLite always inserts a string for CREATE TABLE test (
x TEXT,
tt TEXT NOT NULL DEFAULT current_timestamp,
rr REAL NOT NULL DEFAULT current_timestamp,
ii INTEGER NOT NULL DEFAULT current_timestamp
);
INSERT INTO test(x) VALUES ( 'Hello' );
SELECT * FROM test;
Hello|2024-11-05 17:50:26|2024-11-05 17:50:26|2024-11-05 17:50:26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Julian day calculation I mentioned in #38.
Not entirely sure on the naming I chose, let me know what you think.
Formula deduced from information at https://aa.usno.navy.mil/data/JulianDate