Update 1275 Find Winner on a Tic Tac Toe Game - Change break to continue #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tic Tac Toe solution used `break` inside a loop when the first cell of the column or row was empty. I believe this will result in it skipping all other rows/columns when it reaches a null cell. Instead of using `break` I think it should be `continue` instead. Tested locally and `continue` works for 3 vertical in the last column, where `break` fails to find the winner.
|
Thanks for the pull request. I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tic Tac Toe solution used
breakinside a loop when the first cell of the column or row was empty. I believe this will result in it skipping all other rows/columns when it reaches a null cell. Instead of usingbreakI think it should becontinueinstead.Tested locally and
continueworks for 3 vertical in the last column, wherebreakfails to find the winner.