add re-run last test option #572
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2020 17:51
jdneo
reviewed
Jun 27, 2020
src/commands/test.ts
Outdated
| value: ":file", | ||
| }, | ||
| { | ||
| label: "$(refresh) Re- run last...", |
Member
There was a problem hiding this comment.
UI: Use this icon please: $(debug-restart)
reference: https://microsoft.github.io/vscode-codicons/dist/codicon.html
Member
|
Hey @nathanesau, Thank you for your contribution, and sorry for the late reply... I think it could be better if we use the icon |
Member
|
@nathanesau, will you still have the interest to update the PR? |
Contributor
Author
|
Sorry for the delay. I have made the change (commit "use debug-start icon"):
|
jdneo
reviewed
Jul 24, 2020
| value: ":file", | ||
| }, | ||
| { | ||
| label: "$(debug-restart) Re-run last...", |
Member
There was a problem hiding this comment.
One suggestion here: We should only show the re-run option when the lastTest is not empty. Also, this option should put at the top of the list, to make it more convenient for the users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement request from Issue #570