Minor update to Deep Learning Parser example notebook #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of the Deep Learning Parsing example Notebook lacks the 'inplace=True' parameter on the sort method call to the Layout instance in the left Interval. This version's large block of image data shows these TextBlock's ids in top-down sequential order. Running the Notebook as written, however, will refresh the Notebook page image with out of sequence ids due to the default of the inplace parameter being False. For instructional clarity, this version casts the right_blocks variable as a Layout instance initialized with the TextBlocks not in the left Interval and with inplace=True. A few non-essential additions to the source comments are added relative to the changes described.
The current version of the Deep Learning Parsing example Notebook lacks the 'inplace=True' parameter on the sort method call to the Layout instance in the left Interval. This version's large block of image data shows these TextBlock's ids in top-down sequential order. Running the Notebook as written, however, will refresh the Notebook page image with out of sequence ids due to the default of the inplace parameter being False. For instructional clarity, this version casts the right_blocks variable as a Layout instance initialized with the TextBlocks not in the left Interval and with inplace=True. A few non-essential additions to the source comments are added relative to the changes described.
Member
|
Thank you for the updates, @Jim-Salmons ! I added some minor tweaks to your updates to minimize the unnecessary/hidden Jupyter Notebook changes. But other than that all looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the Deep Learning Parsing example Notebook lacks the
inplace=Trueparameter on the sort method call to the Layout instance in the left Interval. The master version's large block of image data shows these TextBlock's ids in top-down sequential order. Running the Notebook as written, however, will refresh the Notebook page image with out of sequence ids due to the default of theinplaceparameter being False. The current master Notebook will produce the following image post-refresh:For instructional clarity, this version also casts the
right_blocksvariable as a Layout instance initialized with the TextBlock instances not in the left Interval and withinplace=Trueto ensure the intended sort sequencing of block ids.A few non-essential additions to the source comments are added relative to the changes described.
Please note: At 70 years of age, this is my first PR to a public repository. I started my career with no CompSci or engineering experience as a Control Data PLATO developer. I then spent the bulk of my career in Programmer Nirvana as a Smalltalk developer on small teams with brilliant engineers who did all the necessary heavy lifting of integration and testing while I got to explore the nether regions of proof-of-concept ideas. So this is truly a learning experience for me. Any pointers or advice to make this PR useful and acceptable will be greatly appreciated.