refactor: remove broken ask tool in favor of askquestion #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 23, 2025 17:29
The ask tool used Bus events that never reached the tool's subscription due to Instance.state scoping issues. The askquestion tool (upstream PR sst#5958) uses HTTP endpoints and works correctly. Removed: - ask tool registration and implementation - Question namespace schemas - DialogQuestion UI components - TuiEvent.QuestionRequest/Response event types - ask.test.ts tests Updated plan.txt to reference askquestion instead of ask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
asktool implementation that used Bus events which never reached the tool's subscription due to Instance.state scoping issuesaskquestiontool (upstream PR feat(new tool):Adding a new tool to opencode -> askquestion tool sst/opencode#5958) which uses HTTP endpointsChanges
asktool registration and implementationQuestionnamespace schemasDialogQuestionUI componentsTuiEvent.QuestionRequest/Responseevent typesplan.txtprompt to referenceaskquestioninstead ofaskCloses #197