[Snyk] Security upgrade @modelcontextprotocol/sdk from 1.13.1 to 1.26.0#51
[Snyk] Security upgrade @modelcontextprotocol/sdk from 1.13.1 to 1.26.0#51Krosebrook wants to merge 2 commits intomainfrom
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-MODELCONTEXTPROTOCOLSDK-15208843
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @Krosebrook, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security update by upgrading the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades @modelcontextprotocol/sdk to version 1.26.0 to address a security vulnerability. The change itself in genkit-tools/cli/package.json is correct. However, the update is incomplete. As noted in the pull request description, the pnpm-lock.yaml file was not updated, which is a critical issue that prevents the fix from being applied. This must be resolved by running pnpm install. Additionally, for consistency, the peerDependency in js/plugins/mcp/package.json should also be updated to the new version.
| "@genkit-ai/telemetry-server": "workspace:*", | ||
| "@genkit-ai/tools-common": "workspace:*", | ||
| "@modelcontextprotocol/sdk": "^1.13.1", | ||
| "@modelcontextprotocol/sdk": "^1.26.0", |
There was a problem hiding this comment.
While this version bump is correct, the change is incomplete and must be addressed before merging.
- Critical: The
pnpm-lock.yamlfile has not been updated. Please runpnpm installin thegenkit-toolsworkspace to update the lockfile and ensure the security fix is applied. - Medium: For consistency, the
peerDependencyon@modelcontextprotocol/sdkinjs/plugins/mcp/package.jsonshould also be updated to^1.26.0.
There was a problem hiding this comment.
Pull request overview
Upgrades the Genkit CLI’s @modelcontextprotocol/sdk dependency to remediate a Snyk-reported vulnerability in the genkit-tools pnpm dependency set.
Changes:
- Bump
@modelcontextprotocol/sdkingenkit-tools/cli/package.jsonfrom^1.13.1to^1.26.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@genkit-ai/telemetry-server": "workspace:*", | ||
| "@genkit-ai/tools-common": "workspace:*", | ||
| "@modelcontextprotocol/sdk": "^1.13.1", | ||
| "@modelcontextprotocol/sdk": "^1.26.0", |
There was a problem hiding this comment.
The dependency version was bumped in this package.json, but genkit-tools/pnpm-lock.yaml still pins @modelcontextprotocol/sdk to 1.13.1 for the cli importer. As-is, installs will continue to resolve the vulnerable version and the security fix won’t actually be applied. Please regenerate and commit the updated genkit-tools/pnpm-lock.yaml (e.g., run pnpm install from genkit-tools/).
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce8e9b8dca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@genkit-ai/telemetry-server": "workspace:*", | ||
| "@genkit-ai/tools-common": "workspace:*", | ||
| "@modelcontextprotocol/sdk": "^1.13.1", | ||
| "@modelcontextprotocol/sdk": "^1.26.0", |
There was a problem hiding this comment.
Update lockfile to apply SDK security upgrade
This change only updates genkit-tools/cli/package.json, but genkit-tools/pnpm-lock.yaml still records the cli importer on @modelcontextprotocol/sdk ^1.13.1/1.13.1 (lines 44-46), so the committed dependency graph does not actually include the security-fixed version. In CI paths that run cd genkit-tools && pnpm install (for example .github/workflows/go.yml), this mismatch can either fail installation under frozen-lockfile behavior or keep builds pinned to the old vulnerable lock until someone regenerates and commits the lockfile.
Useful? React with 👍 / 👎.
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-MODELCONTEXTPROTOCOLSDK-15208843
Snyk has created this PR to fix 1 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
genkit-tools/cli/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-MODELCONTEXTPROTOCOLSDK-15208843
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Race Condition
Note
Medium Risk
Dependency-only change, but it upgrades an SDK used across the CLI’s MCP integration and could introduce behavioral or compatibility changes at runtime.
Overview
Updates
genkit-tools/cli/package.jsonto bump@modelcontextprotocol/sdkfrom^1.13.1to^1.26.0(Snyk fix for a high-severity race condition).Written by Cursor Bugbot for commit 6c1d221. This will update automatically on new commits. Configure here.
Summary by cubic
Upgrade @modelcontextprotocol/sdk to 1.26.0 in genkit-tools/cli to fix a high-severity race condition. Dependency-only change; no functional impact expected.
Dependencies
Migration
pnpm install(orpnpm up @modelcontextprotocol/sdk).Written for commit 6c1d221. Summary will update on new commits.