fix(consumer): add maxLength and pattern validations for KongConsumer and KongConsumerGroup
#3109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandromodarelli
changed the title
KongConssumer and KongConsumerGroupKongConsumer and KongConsumerGroup
Comment on lines
47
to
49
| // +kubebuilder:validation:MaxLength=128 | ||
| // +kubebuilder:validation:Pattern=`^[\p{L}\p{N}.\-_~+@/\[\]]+(?: [\p{L}\p{N}.\-_~+@/\[\]]+)*$` | ||
| Username string `json:"username,omitempty"` |
Member
There was a problem hiding this comment.
The field allows empty strings (omitempty), but the patterns use + quantifier requiring at least one character. I think we can use * instead of + or set MinLength=1 if we don't want empty string
Contributor
Author
There was a problem hiding this comment.
i prefer to go with * approach, the minlength could be a breaking change
Contributor
Author
There was a problem hiding this comment.
adjusted validation rules and added tests to cover empty username and custom_id fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
Fixes #773
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes