Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…th-value-to-avoid-CSG-issues
adamchalmers
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9000
The issue
Default lenght for Extrude is 5, default blind depth for a hole is 5. This means that users clicking submit quickly end up with CSG issues on holes due to this being a coplanar subtract case.
A solution
Change the default value for blind depth to 2 🤷 Diameter of 1 and depth of 2 seems cool, any thoughts?