Skip to content

Add transpiler extracting sketches to variable#10444

Open
jtran wants to merge 3 commits intomainfrom
jtran/name-sketches
Open

Add transpiler extracting sketches to variable#10444
jtran wants to merge 3 commits intomainfrom
jtran/name-sketches

Conversation

@jtran
Copy link
Contributor

@jtran jtran commented Mar 14, 2026

Part of #10275.

Transform code like this

// comment
myVar = foo
  |> extrude(bar)
  |> baz

into

// comment
sketch1 = foo
myVar = extrude(sketch1, bar)
  |> baz

This has a problem of losing some comments. See public/sketch-solve-samples/t-slot-frame/main.kcl and friends.

Many files are deleted because we found more sketches, tried to transpile them, and they failed.

We also allow experimental features in files that have a sketch block.

This allows us to call more efficient methods on Vec that aren't available on slices.
@jtran jtran added the sketch-solve PRs changing sketch-solve functionality only. label Mar 14, 2026
@vercel
Copy link

vercel bot commented Mar 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modeling-app Ready Ready Preview, Comment Mar 14, 2026 1:25am

Request Review

@jtran jtran force-pushed the jtran/name-sketches branch from dfacd89 to 2959c08 Compare March 14, 2026 01:08
@jtran jtran marked this pull request as ready for review March 14, 2026 01:23
@jtran jtran requested review from a team as code owners March 14, 2026 01:23
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 14, 2026

Merging this PR will not alter performance

✅ 167 untouched benchmarks
⏩ 93 skipped benchmarks1


Comparing jtran/name-sketches (2959c08) with main (517b27c)

Open in CodSpeed

Footnotes

  1. 93 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sketch-solve PRs changing sketch-solve functionality only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant