Remove runtime calls to rustContext.hackSetProgram#10425
Draft
franknoirot wants to merge 3 commits intomainfrom
Draft
Remove runtime calls to rustContext.hackSetProgram#10425franknoirot wants to merge 3 commits intomainfrom
rustContext.hackSetProgram#10425franknoirot wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Towards #10420. This method will be no longer necessary for runtime functionality once we wire up using the current project state whenever necessary, since we have implemented a lifecycle API from the frontend.
franknoirot
force-pushed
the
franknoirot/8014/remove-hackset-program
branch
from
321eb15 to
19f5e62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #10420. This method will be no longer necessary for runtime functionality once we wire up using the current project state whenever necessary, since we have implemented a lifecycle API from the frontend. Needs to be stacked together with Rust-side changes that @jtran will implement in order to make use of the current project state instead of
hack_set_programon the Rust side. Although at least right now I will needhack_set_programto remain available for one test—the Trim tool—which I'm unsure how to migrate to no longer needhackSetProgram.