feat: to dynamic the project information #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuexb
reviewed
Jun 29, 2018
| "name": "react-koa-app", | ||
| "version": "1.0.0", | ||
| "description": "scaffold for create web app with react and koa", | ||
| "name": "{{projectName}}", |
There was a problem hiding this comment.
这样修改有问题吧？如果是模板类型应该是 /template/package.json 吧？直接修改模块的 package.json 会有很多问题。
参考：https://github.com/vuejs-templates/webpack/tree/master/template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复 issue：close
相关 issues：将该项目作为react-koa-app-cli工具的脚手架项目，在项目中使用habdlebars模板引擎语法，以便在cli中和对应的数据compile成一个新的可自定义【projectName】【projectVersion】【projectDescription】的模板。
这个 PR 做了什么？
从哪里开始看？
本 PR 是否有破坏性更改？
如何手动测试？
相关背景知识或者文档？
截屏？
下一步
如果是一个 完成大功能的部分 PR，请告知下一步将做什么？
其它