Fix critical bugs and import organization issues from bot reviewer feedback

[Copilot]

This PR addresses critical bugs and code organization issues identified by automated bot reviewers (Copilot and Sourcery) in PR #13.

Critical Bug Fixes

1. Fixed chunking logic that dropped final chunks

The SimpleChunker._chunk() method was incorrectly skipping the final chunk if it was shorter than the target length:

# Before (buggy)
if len(piece) < self.target_length:
    break  # Drops final chunk!

# After (fixed) 
if not piece:
    break  # Only break if no content

This bug caused data loss when processing README content, as the final sentences would be completely omitted from embeddings.

2. Fixed invalid path usage in starred embeddings

The generate_starred_embeddings() function was calling find_build_files(repo["full_name"]) where repo["full_name"] is a GitHub identifier like "owner/repo", not a local filesystem path. This would cause runtime errors when processing starred repositories:

# Before (buggy)
for build_path in find_build_files(repo["full_name"], patterns=patterns):
    metadata = parse_build_file(os.path.join(repo["full_name"], build_path))

# After (fixed)
repo_path = repo["full_name"]
if os.path.isdir(repo_path):
    for build_path in find_build_files(repo_path, patterns=patterns):
        # Only analyze if local directory exists

The fix safely skips build file analysis for remote repositories while preserving functionality for local ones.

3. Fixed ImportError in test file

Updated test imports to correctly import _post_process_build_files from github_to_sqlite.build_files instead of github_to_sqlite.utils after import reorganization.

Code Organization Improvements

• Moved typing imports to module level: Fixed from typing import statements that were incorrectly placed inside functions in cli.py
• Grouped TYPE_CHECKING import: Moved TYPE_CHECKING import to be grouped with other typing imports in simple_chunker.py
• Modernized string formatting: Replaced .format() with f-string where flagged by bots
• Optimized loop patterns: Replaced for-append loop with more efficient list extend pattern
• Cleaned up unused imports: Removed unused _post_process_build_files import from utils.py
• Fixed test imports: Updated test file to import directly from correct module

Verification

All changes have been verified with:

• ✅ Syntax validation with py_compile
• ✅ Manual testing confirms chunking fix includes final chunks
• ✅ Manual testing confirms import fix resolves ImportError
• ✅ Changes are minimal and preserve existing functionality

These fixes eliminate potential data loss and runtime errors while improving code quality and following Python best practices.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[Copilot]

Pull Request Overview

This PR addresses critical bugs and code organization issues identified by automated bot reviewers, focusing on two main areas: fixing data loss in chunking logic and preventing runtime errors in build file analysis.

• Fixed chunking logic that was dropping final chunks shorter than target length
• Fixed invalid path usage in starred embeddings that would cause runtime errors
• Reorganized import statements and modernized code patterns

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
github_to_sqlite/utils.py	Fixed build file path validation and added error handling for starred repositories
github_to_sqlite/simple_chunker.py	Fixed chunking logic to include final chunks and reorganized typing imports
github_to_sqlite/cli.py	Moved typing imports to module level following Python best practices
github_to_sqlite/build_files.py	Optimized loop pattern using list extend with generator expression
BOT_REVIEW_FIXES.md	Added documentation summarizing all fixes applied

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The function still calls _post_process_build_files() but this import was removed from utils.py. This will cause an ImportError when find_build_files() is called.

[JeffCarpenter]

@copilot fix it

[Copilot]

Fixed the ImportError by updating the test file to import _post_process_build_files directly from github_to_sqlite.build_files instead of github_to_sqlite.utils. The function was always defined in build_files.py but the test was importing it from the wrong module after the import cleanup. Commit 3d4c0d2.