little fix for IndexOfSequence function#2
Open
MichalSiatkowski wants to merge 1 commit intoJeevanJames:masterfrom
Open
little fix for IndexOfSequence function#2MichalSiatkowski wants to merge 1 commit intoJeevanJames:masterfrom
MichalSiatkowski wants to merge 1 commit intoJeevanJames:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when searching bit after bit, when couple of bits of sequence are the same and the next bit is not the same, so the sequence eventually fails to match, you have to come back searching to the begining point + 1 of previous part match, because otherwise you could miss the match in special situation when the valid match starts in the middle of that failed part match