Add sequential kalman filter framework, and EAKF#1224
Open
travissluka wants to merge 1 commit intodevelopfrom
Open
Add sequential kalman filter framework, and EAKF#1224travissluka wants to merge 1 commit intodevelopfrom
travissluka wants to merge 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a test for the sequential EnKF (EAKF in this case)
Also added the
computeLocalization(Point3, Point3)interface to the obs localization so that things would compile and warn us if we tried to use it. We can't use the rossby based localization for sequential EnKF at the moment, though. The rossby based localization needs to callGeometryIterator::getFieldValue()so it will not work with obs/obs localization. The fix to this requires more thought, and Travis has hit his thought quota and can't afford any more credits.Testing
An EAKF test is added, with minimal scientific or technical evaluation (If you run LETKF with GC99 localization and compare it to EAKF, the increments look similar if you squint. And no, I did not think to save those plots)
Dependencies
build-group=https://github.com/JCSDA-internal/oops/pull/3193
build-group=https://github.com/JCSDA-internal/ioda/pull/1674
build-group=https://github.com/JCSDA-internal/ufo/pull/4027
build-group=https://github.com/JCSDA-internal/pyiri-jedi/pull/166