Skip to content

Separate handling of groups and variables in timeseries (optional)#240

Merged
CoryMartin-NOAA merged 2 commits intodevelopfrom
feature/insitu_argo_timeseries
May 8, 2025
Merged

Separate handling of groups and variables in timeseries (optional)#240
CoryMartin-NOAA merged 2 commits intodevelopfrom
feature/insitu_argo_timeseries

Conversation

@Dooruk
Copy link
Collaborator

@Dooruk Dooruk commented May 8, 2025

⚠️ I messed up and I already pushed my changes to develop, see the last two commits. It is a minor change and hopefully won't impact others but I learned my lesson. It is backward compatible.

This simple change allows you to use either the original configuration format or the new one with separate groups and variables. Also adds an example for insitu argo data.

Reduces redundancy IMO, you no longer need to repeat group names in your configuration.

With the new approach it is possible to define groups and variables separately, similar to how it is in other classes.

time_series:

  - begin_date: ...
    final_date: ...
    interval: PT6H

    collection: experiment
    groups:
      - omanPassedQc
      - ombgPassedQc
    variables:
      - salinity
      - waterTemperature
    aggregation_methods:
      - mean
      - count
      - std
    dimension:  Location

closes #231 and #239

@Dooruk Dooruk linked an issue May 8, 2025 that may be closed by this pull request
@Dooruk
Copy link
Collaborator Author

Dooruk commented May 8, 2025

Hmm. Looks like github is using python3.13 now and that might be messing up the requirements and DAG?

Copy link
Collaborator

@karpob karpob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@CoryMartin-NOAA
Copy link
Collaborator

The github CI drives me up the wall with this constant chasing bugs. I vote we force merge this and then try to fix the CI "soon"

@CoryMartin-NOAA CoryMartin-NOAA merged commit 48fe623 into develop May 8, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

accidental push to develop Using anchor and alias in timeseries for variable & channel name templating?

3 participants