Add check on control file and graceful exit,#196
Merged
CoryMartin-NOAA merged 3 commits intodevelopfrom Jul 12, 2024
Merged
Conversation
Contributor
Author
|
For the CI test failure is it a consensus that we need to bump the emcpy version (now at 9b6756341e)? And if so to which version? |
EdwardSafford-NOAA
requested review from
ADCollard,
CoryMartin-NOAA and
kevindougherty-noaa
kevindougherty-noaa
approved these changes
Jul 2, 2024
Contributor
kevindougherty-noaa
left a comment
kevindougherty-noaa
left a comment
There was a problem hiding this comment.
Looks good to me.
Collaborator
@kevindougherty-noaa do you know the answer to this? |
Contributor
Good question. I will have new PR for EMCPy next week with some changes needed for the documentation plus some minor changes. |
Contributor
Author
|
@CoryMartin-NOAA CI tests have passed so this is good to go now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modity
mon_data_space.pyadding a check on the control file and graceful exit if not found. Without this exit the entire plot job terminates. With this exit only the affected thread halts (with error message), allowing all other plots to proceed.This has been tested on wcoss2 by removing some control files from the test data set. Missing control files are reported as warnings and all plots with valid control files run to completion.
Dependencies
None
Resolves #191 .