Fix levels bug in mon_data_space.py#179
Merged
CoryMartin-NOAA merged 1 commit intoJCSDA-internal:developfrom Mar 6, 2024
Merged
Fix levels bug in mon_data_space.py#179CoryMartin-NOAA merged 1 commit intoJCSDA-internal:developfrom
CoryMartin-NOAA merged 1 commit intoJCSDA-internal:developfrom
Conversation
Complete bug fix.
EdwardSafford-NOAA
requested review from
ADCollard,
CoryMartin-NOAA and
kevindougherty-noaa
CoryMartin-NOAA
approved these changes
Mar 6, 2024
Collaborator
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
Good old bug fixes, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Levels implementation as dataset coordinate in
data/mon_data_space.pywas not entirely complete. If the input yaml file requested only a subset of the available levels, as opposed to requesting all levels specified in the control file, the results were sub-optimal. The fix is simple enough -- it now follows the same steps as for the Channel coordinate.Resolves #178 .