Add csv_space.py#164
Merged
CoryMartin-NOAA merged 4 commits intoJCSDA-internal:developfrom Nov 27, 2023
Merged
Conversation
Add data/csv_space.py
Add test yaml and data.
EdwardSafford-NOAA
requested review from
ADCollard,
CoryMartin-NOAA and
kevindougherty-noaa
Collaborator
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
Couple of comments to consider this late Friday afternoon, but otherwise this is looking pretty good, thanks @EdwardSafford-NOAA!
Address header and coordinate issues.
EdwardSafford-NOAA
force-pushed
the
feature/csv-163
branch
from
af41b61 to
d588c42
Compare
CoryMartin-NOAA
approved these changes
Nov 27, 2023
Collaborator
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
Looks good as far as I can tell, thanks @EdwardSafford-NOAA for another great addition!
kevindougherty-noaa
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
data/csv_space.pyto load csv data from csv files. Most immediately this is to be used with the MinMon summary plots, though I've tried to make it as generic as possible to support other uses.Dependencies
None
Impact
None